Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-review: 0.6.1 -> 1.0.1 #51434

Merged
merged 1 commit into from Dec 3, 2018
Merged

nix-review: 0.6.1 -> 1.0.1 #51434

merged 1 commit into from Dec 3, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 3, 2018

  • use nix build instead of nix-build
  • writes per-build log in the current working directory
  • symlinks the builds in the current working directory
  • detects & deduplicates build aliases
  • markdown reports
  • filter builds by regex
  • generate nix expression files that can be build by the user
  • fix large rebuilds where package names where to large to be passed directly to nix-shell
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" nix-review pr 51434
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- use nix build instead of nix-build
- writes per-build log in the current working directory
- symlinks the builds in the current working directory
- detects & deduplicates build aliases
- markdown reports
- filter builds by regex
- generate nix expression files that can be build by the user
@Mic92 Mic92 changed the title nix-review: 0.6.1 -> 1.0.0 nix-review: 0.6.1 -> 1.0.1 Dec 3, 2018
@Mic92 Mic92 merged commit 01d864c into NixOS:master Dec 3, 2018
@Mic92 Mic92 deleted the nix-review branch December 3, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants