Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logind: make killUserProcesses an option #51426

Merged
merged 1 commit into from Dec 11, 2018
Merged

logind: make killUserProcesses an option #51426

merged 1 commit into from Dec 11, 2018

Conversation

benley
Copy link
Member

@benley benley commented Dec 3, 2018

Right now it's not at all obvious that one can override this option using services.logind.extraConfig; we might as well add an option for killUserProcesses directly so it's clear and documented.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley benley mentioned this pull request Dec 3, 2018
Closed
@benley benley force-pushed the logind-killuserprocesses branch 2 times, most recently from dac27ab to a62a453 Compare December 3, 2018 21:13
@benley
Copy link
Member Author

benley commented Dec 11, 2018

If there are no objections I'd like to merge this in the next few days.

@benley
logind: make killUserProcesses an option
d859efa 
Right now it's not at all obvious that one can override this option
using `services.logind.extraConfig`; we might as well add an option
for `killUserProcesses` directly so it's clear and documented.
@benley benley merged commit 1181d61 into NixOS:master Dec 11, 2018
@benley benley deleted the logind-killuserprocesses branch December 11, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benley @GrahamcOfBorg