Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (#49446) #51414

Merged
merged 1 commit into from Dec 2, 2018
Merged

Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (#49446) #51414

merged 1 commit into from Dec 2, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 2, 2018

Motivation for this change

This reverts commit 9512841.

The update is causing segfaults. See
https://trac.sagemath.org/ticket/26442.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner December 2, 2018 23:01
@timokau timokau changed the title Revert "pythonPackages.cypari2: 1.2.1 -> 1.3.1" Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (#49446) Dec 2, 2018
@timokau timokau removed the request for review from FRidh December 2, 2018 23:12
@timokau timokau merged commit 5f2b8de into NixOS:master Dec 2, 2018
@timokau timokau deleted the cypari2-revert branch December 2, 2018 23:44
@timokau timokau mentioned this pull request Dec 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg