Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.5.3 -> 1.6.0 #51386

Merged
merged 1 commit into from Dec 5, 2018
Merged

gitea: 1.5.3 -> 1.6.0 #51386

merged 1 commit into from Dec 5, 2018

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Dec 2, 2018

Motivation for this change

Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.6.0

from the security section:

  • Add CSRF checking to reqToken and add reqToken to admin API routes
  • Improve URL validation for external wiki and external issues
  • Make cookies HttpOnly and obey COOKIE_SECURE flag
  • Don't disclose emails of all users when sending out emails
  • Check that repositories can only be migrated to own user or organizations
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

@GrahamcOfBorg build gitea

@markuskowa
Copy link
Member

Let's see aarch64 does not run into trouble with thread limits on the second try:
@GrahamcOfBorg build gitea

@markuskowa
Copy link
Member

@GrahamcOfBorg test gitea

@markuskowa
Copy link
Member

@GrahamcOfBorg build nixosTests.gitea

@markuskowa
Copy link
Member

aarch64 fails with

runtime: failed to create new OS thread (have 6 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Same problem with the last PR: #50229
However, Hydra could build it: https://hydra.nixos.org/build/85306028

@markuskowa markuskowa merged commit 0236b34 into NixOS:master Dec 5, 2018
@cryptix cryptix deleted the update/gitea branch December 5, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cryptix @markuskowa @flokli @GrahamcOfBorg