New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all-packages.nix: Alias self to res, deprecating self #51401
Conversation
For historical reasons, self was ill-named. This removes its usages from all-packages.nix and provides a deprecation message for those who use a patched Nixpkgs. Some packages seem to depend on the peculiarities of res, as can be seen by making res into an alias of pkgs (normally "self"). The super variable doesn't have all that is needed. Therefore the simple fix is not guaranteed to work and as such, usages of res need to be changed to pkgs or super, case by case.
Since we use rec here i think we could just get rid of res. |
@matthewbauer I don't see a |
Oh maybe not then! |
So we have |
Can we just go straight to |
@Ericson2314 When switching, some hashes change, so it's not guaranteed to work. |
Fair enough. If you want to make the next one removing all the |
The warning here breaks tarball: |
This reference was added to master while the deprecation PR NixOS#51401 was open.
This reference was added to master while the deprecation PR #51401 was open.
IMHO, |
It's now been removed! |
For historical reasons, self in
all-packages.nix
was ill-named. This removes its usages fromall-packages.nix
and provides a deprecation message for those who use a patched Nixpkgs.Some packages seem to depend on the peculiarities of res, as can be seen by making res into an alias of
pkgs
(normallyself
). Thesuper
variable doesn't have all attributes that are needed.Therefore the simple fix is not guaranteed to work and as such,
usages of
res
need to be changed topkgs
orsuper
, case by case.Motivation for this change
#34881
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)