Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtools: 4.0.21 -> 4.0.22 #51432

Merged
merged 1 commit into from Dec 8, 2018
Merged

mtools: 4.0.21 -> 4.0.22 #51432

merged 1 commit into from Dec 8, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 3, 2018

https://lists.gnu.org/archive/html/info-gnu/2018-12/msg00000.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 3, 2018

Looks like candidate for master.

@dtzWill dtzWill changed the base branch from staging to master December 8, 2018 03:55
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 8, 2018

@GrahamcOfBorg build syslinux

@c0bw3b c0bw3b merged commit 0c97fbc into NixOS:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @Mic92 @c0bw3b @GrahamcOfBorg