Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assaultcube: fix version schema #51423

Closed
wants to merge 1 commit into from
Closed

assaultcube: fix version schema #51423

wants to merge 1 commit into from

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 3, 2018

Motivation for this change

Change version to correct schema.

cc maintainer @bignaux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@davidak Can you elaborate on what this will correct?

From looking at the changes I can discern that version now matches nixpkgs guidelines.
Though that has unintended issues for nix-env users apparently.

@davidak
Copy link
Member Author

davidak commented Dec 6, 2018

From looking at the changes I can discern that version now matches nixpkgs guidelines.

It's just that. It don't fixes any technical issue.

Though that has unintended issues for nix-env users apparently.

What do you mean? Something with comparing the versions? Even when it would be a breaking change, i think it would be OK in master.

@worldofpeace
Copy link
Contributor

Sorry, the word schema in the commit msg threw me off.
Also I checked and nix-env will see this version as newer so we're good 👍

@worldofpeace
Copy link
Contributor

Merged in bb0214c

@davidak davidak deleted the ac branch December 6, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants