metrics.nix: add a metrick for the current number of packages as seen by nix-env #49863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edolstra, @vcunat, can we have this one, please? As I noted in #38635 (comment) without this current hydra's metrics don't make that much sense. |
infinisil
requested changes
Nov 11, 2018
pkgs/top-level/metrics.nix
Outdated
| @@ -49,6 +49,9 @@ runCommand "nixpkgs-metrics" | |||
| run nix-env.qa nix-env -f ${nixpkgs} -qa | |||
| run nix-env.qaDrv nix-env -f ${nixpkgs} -qa --drv-path --meta --xml | |||
|
|
|||
| num=$(nix-env -f ${nixpkgs} -qa --drv-path --meta --xml | grep '<item ' | wc -l) | |||
| echo "nix-env.qaDrv.number $num" >> $out/nix-support/hydra-metrics | |||
There was a problem hiding this comment.
How about just nix-env -f ${nixpkgs} -qa | wc -l
Also, I'd prefer the name "count" instead of "number"
oxij
force-pushed
the
tree/packages-metric
branch
from
761b248
to
9d35a02
Compare
The results differ slightly, but that is not particularly important. Changed.
Done. |
infinisil
approved these changes
Nov 17, 2018
|
Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A tiny piece of #45841 I would like to be applied anyway.
Things done
It is a bit hacky, but