Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtbase: add cf-private on darwin #49845

Merged
merged 1 commit into from Nov 7, 2018
Merged

qt5.qtbase: add cf-private on darwin #49845

merged 1 commit into from Nov 7, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Nov 7, 2018

Motivation for this change

Follow up for #49768

Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSDate", referenced from:
      objc-class-ref in qcore_foundation.o
  "_OBJC_CLASS_$_NSURL", referenced from:
      objc-class-ref in qcore_foundation.o
  "_OBJC_CLASS_$_NSData", referenced from:
      objc-class-ref in qcore_foundation.o
  "_CFURLCopyResourcePropertyForKey", referenced from:
      hasResourcePropertyFlag(QFileSystemMetaData const&, QFileSystemEntry const&, __CFString const*) in qfilesystemengine_unix.o
  "_CFURLCreateBookmarkDataFromFile", referenced from:
      QFileSystemEngine::getLinkTarget(QFileSystemEntry const&, QFileSystemMetaData&) in qfilesystemengine_unix.o
  "_kCFURLIsAliasFileKey", referenced from:
      QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
  "_kCFURLIsHiddenKey", referenced from:
      QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
  "_kCFURLIsPackageKey", referenced from:
      QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
  "_CFURLCreateByResolvingBookmarkData", referenced from:
      QFileSystemEngine::getLinkTarget(QFileSystemEntry const&, QFileSystemMetaData&) in qfilesystemengine_unix.o
ld: symbol(s) not found for architecture x86_64
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
qt5.qtbase: add cf-private on darwin
9a1a872 
    Undefined symbols for architecture x86_64:
      "_OBJC_CLASS_$_NSDate", referenced from:
          objc-class-ref in qcore_foundation.o
      "_OBJC_CLASS_$_NSURL", referenced from:
          objc-class-ref in qcore_foundation.o
      "_OBJC_CLASS_$_NSData", referenced from:
          objc-class-ref in qcore_foundation.o
      "_CFURLCopyResourcePropertyForKey", referenced from:
          hasResourcePropertyFlag(QFileSystemMetaData const&, QFileSystemEntry const&, __CFString const*) in qfilesystemengine_unix.o
      "_CFURLCreateBookmarkDataFromFile", referenced from:
          QFileSystemEngine::getLinkTarget(QFileSystemEntry const&, QFileSystemMetaData&) in qfilesystemengine_unix.o
      "_kCFURLIsAliasFileKey", referenced from:
          QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
      "_kCFURLIsHiddenKey", referenced from:
          QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
      "_kCFURLIsPackageKey", referenced from:
          QFileSystemEngine::fillMetaData(QFileSystemEntry const&, QFileSystemMetaData&, QFlags<QFileSystemMetaData::MetaDataFlag>) in qfilesystemengine_unix.o
      "_CFURLCreateByResolvingBookmarkData", referenced from:
          QFileSystemEngine::getLinkTarget(QFileSystemEntry const&, QFileSystemMetaData&) in qfilesystemengine_unix.o
    ld: symbol(s) not found for architecture x86_64
@LnL7 LnL7 requested a review from ttuegel as a code owner November 7, 2018 00:20
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qt5.qtbase

Partial log (click to expand)

these paths will be fetched (8.60 MiB download, 33.21 MiB unpacked):
  /nix/store/6cm7plahdk3sgcynv506cj416g37bljc-libinput-1.12.2
  /nix/store/c4d9qgyyx6p2gydbbh5wpp4mxvwgc64n-qtbase-5.11.1-bin
  /nix/store/r6n4b9crppc0rmrr2z46xkqa87agydqy-qtbase-5.11.1
  /nix/store/wlfk41rdg69vl2rsh1ib7lpda837v27j-libwacom-0.29
copying path '/nix/store/wlfk41rdg69vl2rsh1ib7lpda837v27j-libwacom-0.29' from 'https://cache.nixos.org'...
copying path '/nix/store/6cm7plahdk3sgcynv506cj416g37bljc-libinput-1.12.2' from 'https://cache.nixos.org'...
copying path '/nix/store/r6n4b9crppc0rmrr2z46xkqa87agydqy-qtbase-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/c4d9qgyyx6p2gydbbh5wpp4mxvwgc64n-qtbase-5.11.1-bin' from 'https://cache.nixos.org'...
/nix/store/c4d9qgyyx6p2gydbbh5wpp4mxvwgc64n-qtbase-5.11.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qt5.qtbase

Partial log (click to expand)

Removing empty /nix/store/g1y7p77my137cyw5ymqkrvj5l6a1rrfw-qtbase-5.11.1/bin/ and (possibly) its parents
Moving /nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin/uic to /nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/bin/uic
rmdir: failed to remove '/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin': Directory not empty
updateToolPath: Updating `/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin/uic' in `/nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/lib/cmake/Qt5Widgets/Qt5WidgetsConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin/moc' in `/nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin/qmake' in `/nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin/rcc' in `/nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
Moving /nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin/bin to /nix/store/k6iaw5lx45381dd1jk3x1q5cm81f93ln-qtbase-5.11.1-dev/bin
rmdir: failed to remove '/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin': Directory not empty
/nix/store/3zm2bdak3dh2camzg1a8nssn17r9zlfx-qtbase-5.11.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: qt5.qtbase

Partial log (click to expand)

Removing empty /nix/store/r0m53mbrcqdfgxdf5lmkzs9zqs9f1nhk-qtbase-5.11.1/bin/ and (possibly) its parents
Moving /nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin/uic to /nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/bin/uic
rmdir: failed to remove '/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin': Directory not empty
updateToolPath: Updating `/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin/moc' in `/nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin/qmake' in `/nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin/rcc' in `/nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake\'...
updateToolPath: Updating `/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin/uic' in `/nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/lib/cmake/Qt5Widgets/Qt5WidgetsConfigExtras.cmake\'...
Moving /nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin/bin to /nix/store/408498p1hy95n63i9b1nyg5nqbf0adi5-qtbase-5.11.1-dev/bin
rmdir: failed to remove '/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin': Directory not empty
/nix/store/63j8dna2ididnvgbr3yqg2wly6xjykng-qtbase-5.11.1-bin

@LnL7 LnL7 merged commit 26cce54 into NixOS:master Nov 7, 2018
@LnL7 LnL7 deleted the darwin-qtbase branch November 7, 2018 07:24
@LnL7 LnL7 mentioned this pull request Nov 17, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg