trivial: tiny cleanups and fixes #49864

oxij · 2018-11-07T09:08:36Z

Running with these applied.

GrahamcOfBorg · 2018-11-07T09:31:24Z

Success on x86_64-linux (full log)

Attempted: espeak-ng, mesa

Partial log (click to expand)

copying path '/nix/store/dx73vl5hk3883kg4gnqpcyxf6gkji023-flac-1.3.2' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/gc6hmwhp4k17lpcssjwi5pjn09qfr7nw-libvorbis-1.3.6' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/8zqhfxdvz5r8mh66rmxsg02wpr0wfyxa-sonic-2016-03-01' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/6pr06lwr0fl6jl5nzmgqjif6h503ivpb-libsndfile-1.0.28' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/x1nkxjschn3fw6bmi05gly10nhzvdd9c-speexdsp-1.2rc3' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/dl6q0sya45sij9gmn0xnchiq484ayn86-libpulseaudio-12.2' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/3l366nd30bzpyyh8lfdgxbs540qqwn8z-pcaudiolib-2016-07-19' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2
/nix/store/mfbspg0y079dl8dcrk5rsh3mh10wjwmp-mesa-noglu-18.2.2

GrahamcOfBorg · 2018-11-07T09:35:35Z

Success on aarch64-linux (full log)

Attempted: espeak-ng, mesa

Partial log (click to expand)

shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/bin/speak-ng
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib/libespeak-ng-test.so.1.1.49
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib/libespeak-ng.so.1.1.49
gzipping man pages under /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib  /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/bin
patching script interpreter paths in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2
checking for references to /build in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2...
/nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2
/nix/store/ywxaw0sb94xxswqap1aygipw69y3m9my-mesa-noglu-18.2.2

roberth · 2018-11-07T14:40:35Z

pkgs/applications/networking/browsers/firefox/common.nix

@@ -18,7 +18,7 @@
 ## optional libraries

 , alsaSupport ? stdenv.isLinux, alsaLib
-, pulseaudioSupport ? true, libpulseaudio
+, pulseaudioSupport ? stdenv.isLinux, libpulseaudio


Commit message should be descriptive like "firefox: disable pulseaudio support on non-Linux by default"

roberth · 2018-11-07T14:42:15Z

nixos/release.nix

@@ -108,7 +108,7 @@ let
    let
      configEvaled = import lib/eval-config.nix {
        inherit system;
-        modules = [ module versionModule ];
+        modules = [ configuration module versionModule ];


Looks like [ configuration module versionModule ] should be factored out across the entire file.

ttuegel

Qt changes look fine to me.

oxij · 2018-11-08T05:23:55Z

@roberth done.

oxij · 2018-11-08T05:33:29Z

Also pushed a piece of #49862 here.

GrahamcOfBorg · 2018-11-08T05:39:09Z

Success on x86_64-linux (full log)

Attempted: espeak-ng, mesa

Partial log (click to expand)

these paths will be fetched (2.21 MiB download, 6.75 MiB unpacked):
  /nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2
  /nix/store/3l366nd30bzpyyh8lfdgxbs540qqwn8z-pcaudiolib-2016-07-19
copying path '/nix/store/3l366nd30bzpyyh8lfdgxbs540qqwn8z-pcaudiolib-2016-07-19' from 'https://cache.nixos.org'...
copying path '/nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2' from 'https://cache.nixos.org'...
/nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2
/nix/store/mfbspg0y079dl8dcrk5rsh3mh10wjwmp-mesa-noglu-18.2.2

GrahamcOfBorg · 2018-11-08T05:44:57Z

Success on x86_64-linux (full log)

Attempted: espeak-ng, gnuradio-rds, mesa

Partial log (click to expand)

copying path '/nix/store/x4kkl7js1366w25vljgwdd7ciccw1x31-python2.7-PyQt-x11-gpl-4.12' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/2dkvlz3x1jf83s9zmn9klh6d3jf8icgh-qwt-6.1.3' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/zmddrmjvcsqwg1br6vkyx3ynbab54bqx-uhd-3.12.0.0' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/qhw4mb6rk3ysx9n3w57q6v87ac5nca9q-wxwidgets-3.0.4' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/gzn0ywb6ajf5v0a0yfn82gwxrxjbanrh-python2.7-wxPython-3.0.2.0' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/0z787nql9xx49w6f5frvvma87yz6bg0p-gnuradio-3.7.13.4' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/4xk956ax1wfwqalwaiww912pab3zg9ci-gnuradio-rds-1.0.0' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/0s5x9k8c4qz93kh7d20gd4kapyg7l8z2-espeak-ng-1.49.2
/nix/store/4xk956ax1wfwqalwaiww912pab3zg9ci-gnuradio-rds-1.0.0
/nix/store/mfbspg0y079dl8dcrk5rsh3mh10wjwmp-mesa-noglu-18.2.2

GrahamcOfBorg · 2018-11-08T05:49:29Z

Success on aarch64-linux (full log)

Attempted: espeak-ng, mesa

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/bin/espeak-ng
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/bin/speak-ng
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib/libespeak-ng-test.so.1.1.49
shrinking /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib/libespeak-ng.so.1.1.49
gzipping man pages under /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/lib  /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2/bin
patching script interpreter paths in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2
checking for references to /build in /nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2...

GrahamcOfBorg · 2018-11-08T06:32:50Z

Success on aarch64-linux (full log)

Attempted: espeak-ng, gnuradio-rds, mesa

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0
shrinking /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0/lib/python2.7/site-packages/rds/_rds_swig.so
shrinking /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0/lib/libgnuradio-rds-3.7.0git.so.0.0.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0/lib
patching script interpreter paths in /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0
checking for references to /build in /nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0...
/nix/store/3sq9iscbz3v3c7az4kn9phs713yc9cw4-espeak-ng-1.49.2
/nix/store/zrkzcpj5qdx2zrh15kh77c6pk9dmwrn5-gnuradio-rds-1.0.0
/nix/store/ywxaw0sb94xxswqap1aygipw69y3m9my-mesa-noglu-18.2.2

oxij requested review from edolstra, nbp and ttuegel as code owners November 7, 2018 09:08

oxij force-pushed the pkgs/tiny-things branch from fe3ddf6 to 43965b2 Compare November 7, 2018 09:10

GrahamcOfBorg added 6.topic: nixos 6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Nov 7, 2018

roberth reviewed Nov 7, 2018

View reviewed changes

ttuegel reviewed Nov 8, 2018

View reviewed changes

oxij added 6 commits November 8, 2018 05:20

nixos/release.nix: generalize modules copy-paste into makeModules

2403464

firefox: disable pulseaudio support on non-Linux by default

d2d80e6

lib: commitIdFromGitRepo: simplify a tiny bit

2f5e4c7

espeak-ng: tiny cleanup

f623f8c

qt5: use https, tiny cleanup

c0a4e46

mesa: tiny cleanup

3902085

oxij force-pushed the pkgs/tiny-things branch from 43965b2 to 3902085 Compare November 8, 2018 05:23

oxij added 2 commits November 8, 2018 05:29

tree-wide: fix all revs of fetchsvn

67a5c0d

gnuradio-rds: fix src

56802ad

GrahamcOfBorg added the 6.topic: printing label Nov 8, 2018

GrahamcOfBorg added 10.rebuild-linux: 101-500 and removed 10.rebuild-linux: 0 labels Nov 8, 2018

7c6f434c merged commit adf41ed into NixOS:master Nov 8, 2018

oxij deleted the pkgs/tiny-things branch November 18, 2018 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

trivial: tiny cleanups and fixes #49864

trivial: tiny cleanups and fixes #49864

oxij commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

roberth Nov 7, 2018

roberth Nov 7, 2018

ttuegel left a comment

oxij commented Nov 8, 2018

oxij commented Nov 8, 2018 via email

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

trivial: tiny cleanups and fixes #49864

trivial: tiny cleanups and fixes #49864

Conversation

oxij commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

roberth Nov 7, 2018

Choose a reason for hiding this comment

roberth Nov 7, 2018

Choose a reason for hiding this comment

ttuegel left a comment

Choose a reason for hiding this comment

oxij commented Nov 8, 2018

oxij commented Nov 8, 2018 via email

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018