Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd: 6.4.0p1 -> 6.4.0p2 #49846

Merged
merged 1 commit into from Nov 9, 2018
Merged

opensmtpd: 6.4.0p1 -> 6.4.0p2 #49846

merged 1 commit into from Nov 9, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Nov 7, 2018

Motivation for this change

Should fix the issues mentioned at #48901 (comment) and after, and on IRC.

See upstream OpenSMTPD/OpenSMTPD#886

cc @obadz @rickynils @the-kenny @Izorkin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ekleog
Copy link
Member Author

Ekleog commented Nov 7, 2018

@GrahamcOfBorg test opensmtpd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opensmtpd

Partial log (click to expand)

shrinking /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/libexec/opensmtpd/mail.lmtp
shrinking /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/sbin/smtpctl
shrinking /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/sbin/smtpd
/nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2
gzipping man pages under /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/libexec  /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/bin  /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/sbin
patching script interpreter paths in /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2
checking for references to /build in /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2...
moving /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/sbin/* to /nix/store/xq5cnzxfw4ad6cmljkfffvs5s134qif0-opensmtpd-6.4.0p2/bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opensmtpd

Partial log (click to expand)

shrinking /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/libexec/opensmtpd/mail.maildir
shrinking /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/sbin/smtpd
shrinking /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/sbin/smtpctl
gzipping man pages under /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/libexec  /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/bin  /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/sbin
patching script interpreter paths in /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2
checking for references to /build in /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2...
moving /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/sbin/* to /nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2/bin
/nix/store/vyv90gc4i8yf5p3bdjihpms3fi0sk9y9-opensmtpd-6.4.0p2

@Izorkin
Copy link
Contributor

Izorkin commented Nov 7, 2018

Thanks, worked.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

error: timed out waiting for the VM to connect
timed out waiting for the VM to connect
cleaning up
killing client (pid 600)
killing smtp2 (pid 612)
killing smtp1 (pid 624)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/fqrgm6lgi4lhacsb83zw64h413wy243n-vm-test-run-opensmtpd.drv' failed with exit code 4
error: build of '/nix/store/fqrgm6lgi4lhacsb83zw64h413wy243n-vm-test-run-opensmtpd.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

client: running command: sync
client: exit status 0
test script finished in 473.72s
cleaning up
killing smtp2 (pid 631)
killing smtp1 (pid 643)
killing client (pid 656)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/xbzgbxsm575gbgihs6m7i081dkri5jb8-vm-test-run-opensmtpd

@Ekleog
Copy link
Member Author

Ekleog commented Nov 7, 2018

Huh? the test passes locally, this looks like usual flakiness of connect timeouts?

@GrahamcOfBorg test opensmtpd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

client: running command: sync
client: exit status 0
test script finished in 141.41s
cleaning up
killing smtp2 (pid 631)
killing smtp1 (pid 644)
killing client (pid 657)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/aqjkh6br42lng3wrmj2595dhs1gkyc8h-vm-test-run-opensmtpd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

client: running command: sync
client: exit status 0
test script finished in 35.61s
cleaning up
killing smtp2 (pid 597)
killing smtp1 (pid 609)
killing client (pid 621)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/x6ph8d5l93va8rfbr8biyhj9dr7a0vpy-vm-test-run-opensmtpd

@c0bw3b c0bw3b merged commit d7cfa87 into NixOS:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @GrahamcOfBorg @Izorkin @c0bw3b