Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
base: 13892da3e763
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
compare: 797e0d84a180
Choose a head ref
  • 5 commits
  • 10 files changed
  • 3 contributors

Commits on Oct 30, 2018

  1. dovecot, opensmtpd: add link to test in meta.tests

    Rationale
    ---------
    
    Currently, tests are hard to discover. For instance, someone updating
    `dovecot` might not notice that the interaction of `dovecot` with
    `opensmtpd` is handled in the `opensmtpd.nix` test.
    
    And even for someone updating `opensmtpd`, it requires manual work to go
    check in `nixos/tests` whether there is actually a test, especially
    given not so many packages in `nixpkgs` have tests and this is thus most
    of the time useless.
    
    Finally, for the reviewer, it is much easier to check that the “Tested
    via one or more NixOS test(s)” has been checked if the file modified
    already includes the list of relevant tests.
    
    Implementation
    --------------
    
    Currently, this commit only adds the metadata in the package. Each
    element of the `meta.tests` attribute is a derivation that, when it
    builds successfully, means the test has passed (ie. following the same
    convention as NixOS tests).
    
    Future Work
    -----------
    
    In the future, the tools could be made aware of this `meta.tests`
    attribute, and for instance a `--with-tests` could be added to
    `nix-build` so that it also builds all the tests. Or a `--without-tests`
    to build without all the tests. @Profpatsch described in his NixCon talk
    such systems.
    
    Another thing that would help in the future would be the possibility to
    reasonably easily have cross-derivation nix tests without the whole
    NixOS VM stack. @7c6f434c already proposed such a system.
    
    This RFC currently handles none of these concerns. Only the addition of
    `meta.tests` as metadata to be used by maintainers to remember to run
    relevant tests.
    Ekleog committed Oct 30, 2018
    Copy the full SHA
    02e1f00 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Merge pull request #44439 from Ekleog/meta-tests

    [RFC] Use `meta.tests` to link from packages to the tests that test them
    timokau committed Nov 6, 2018
    Copy the full SHA
    6141939 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. shadowsocks-libev: set install name correctly

    This avoids having to invoke install_name_tool.
    matthewbauer committed Nov 7, 2018
    Copy the full SHA
    147ff75 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8511f04 View commit details
    Browse the repository at this point in the history
  3. podofo: cleanup

    matthewbauer committed Nov 7, 2018
    Copy the full SHA
    797e0d8 View commit details
    Browse the repository at this point in the history