Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/triggerhappy: add option user #49868

Merged
merged 1 commit into from Apr 11, 2019
Merged

nixos/triggerhappy: add option user #49868

merged 1 commit into from Apr 11, 2019

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Having a global hotkey daemon with no root privileges doesn’t make too much sense. See actkbd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Does it not work without this or what? If it works without root privileges, that's something good

@jfrankenau jfrankenau changed the title nixos/triggerhappy: do not drop to user nobody nixos/triggerhappy: add option user Nov 12, 2018
@jfrankenau
Copy link
Member Author

You are right. I’ve instead added an option for specifying the user under which triggerhappy should run which allows one to use the root user if it is necessary to get the permission to run certain commands.

tomberek
tomberek approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not break existing setups.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@ryantm ryantm merged commit 0960fc7 into NixOS:master Apr 11, 2019
@jfrankenau jfrankenau deleted the fix-triggerhappy branch April 18, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jfrankenau @infinisil @nixos-discourse @tomberek @ryantm @GrahamcOfBorg