Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtiff: 4.0.9 -> 2018-11-04 #49860

Merged
merged 1 commit into from Nov 10, 2018
Merged

libtiff: 4.0.9 -> 2018-11-04 #49860

merged 1 commit into from Nov 10, 2018

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Nov 7, 2018

Motivation for this change

This includes a bunch of security fixes (#49786), and mimics what Debian has done in moving to a git snapshot instead of a released version + backported security patches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

(there don't appear to be any maintainers for libtiff to cc)

Synthetica9
Synthetica9 requested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@Synthetica9 Synthetica9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nixos.org/nixpkgs/manual/#sec-package-naming

pkgs/development/libraries/libtiff/default.nix
stdenv.mkDerivation rec {
version = "2018-11-04";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "2018-11-04";
version = "unstable-2018-11-04";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Based on the guidelines, I put the unstable in the package name, not version, but 👍

@andrew-d
libtiff: 4.0.9 -> 2018-11-04
3137c60 
This includes a bunch of security fixes (NixOS#49786), and mimics what Debian
has done in moving to a git snapshot instead of a released version +
backported security patches.
@andrew-d
Copy link
Contributor Author

@Synthetica9 - sorry for the ping, but anything I can do to help get this merged?

@andrew-d andrew-d mentioned this pull request Nov 10, 2018
Open
@Synthetica9
Copy link
Member

Synthetica9 commented Nov 10, 2018 via email

@Mic92
Copy link
Member

Mic92 commented Nov 10, 2018

@GrahamcOfBorg build graphicsmagick

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)

Attempted: graphicsmagick

Partial log (click to expand)

cannot build derivation '/nix/store/8y1xarz84imwanqk3k8vghdwfrp4pjln-absolute_gir_path.patch.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ibfahkfyw95wwl7pdv6vvjs94y1w6h8g-harfbuzz-2.1.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ccijrmks3l6pn8gnf188wkckz5zfmqwk-mesa-noglu-18.2.4.drv': 31 dependencies couldn't be built
cannot build derivation '/nix/store/v20nx6gf9k8j9jb19xl9f57797r66ip4-gobject-introspection-1.56.0.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/a09c2bqqb1drb18n1a60yw2kyq6hvq8x-libGL-1.0.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0c16hab08mml05syqc89c5ixq2kgxkxx-libdevil-1.7.8.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/7i8pd0qphriwpappra6j8imxyz25w380-pango-1.42.4.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/pga20lhdbhz14rz11jz83fm638pb3pgm-graphviz-2.40.1.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/39kpa0lhaqvzbifkwi0c3qkkxnb0snm0-graphicsmagick-1.3.30.drv': 12 dependencies couldn't be built
error: build of '/nix/store/39kpa0lhaqvzbifkwi0c3qkkxnb0snm0-graphicsmagick-1.3.30.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: graphicsmagick

Partial log (click to expand)

shrinking /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/lib/libGraphicsMagick.so.3.18.1
gzipping man pages under /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/share/man/
strip is /nix/store/426i2d272x6c8j4shwl1377xj2cf1ijj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/lib  /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin
patching script interpreter paths in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagick-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30/bin/GraphicsMagick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/dsvsl7r2vqvjilphj8ci8skxkib89xsa-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30...
/nix/store/r34ms9zr5v6l93n04h4sb82h5pm01hyc-graphicsmagick-1.3.30

@Mic92 Mic92 merged commit f2d2a8f into NixOS:staging Nov 10, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: graphicsmagick

Partial log (click to expand)

shrinking /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/gm
gzipping man pages under /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/share/man/
strip is /nix/store/xzn29jrdk6czmx5qai15v6hwsrxviw4c-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/lib  /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin
patching script interpreter paths in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagick-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30/bin/GraphicsMagick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/bz05mnzgipkkcvlr3l6avvh659ck7zrf-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30...
/nix/store/kh3pi565d5qcnv56ghqx9b1has0wprzn-graphicsmagick-1.3.30

@andrew-d andrew-d deleted the andrew/upgrade-libtiff branch November 11, 2018 02:49
@andrew-d andrew-d mentioned this pull request Nov 27, 2018
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Synthetica9 requested changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrew-d @Synthetica9 @Mic92 @GrahamcOfBorg @c0bw3b