I think this PR at least partially overlaps with #49414

I don't think it overlaps with #49414 since the PR #49414 simplifies the dockerTools.buildImageWithNix function which is not used in the context of this PR.

Ah, I just saw docker image and closureinfo were mentioned both places :) So this is good to go in your opinion, then?

@dingxiangfei2009 It seems there are some changes that are not related to the commit message (the Docker FS layout for instance). This makes your commit harder to review.

• How could I test this changes?
• I also wonder how you use this Docker profile:/
• Did you check the cd-dvd build is still working?

@nlewo
Here is how I tested this.
default.nix:

let
  nixos = import <nixpkgs/nixos> {
    configuration = ./configuration.nix;
    system = "x86_64-linux";
  };
in
nixos.config.system.build.tarball

configuration.nix:

{ pkgs, config, lib, ... }:
{
  imports = [
    <nixpkgs/nixos/modules/virtualisation/docker-image.nix>
    <nixpkgs/nixos/modules/installer/cd-dvd/channel.nix>
  ];

  documentation.doc.enable = false;

  environment.systemPackages = with pkgs; [
    bashInteractive
    cacert
    nix
  ];
}

Then running nix-build against default.nix gives you a tarball.
To load into docker, run docker import result/tarball/nixos-system-*.tar.xz nixos-docker.
If you do docker run --privileged -it nixos-docker /init, you will see systemd starting up.
Then you can log into this container through docker exec -it <container-name> /run/current-system/sw/bin/bash.

CD/DVD builds are still working. In fact, currently only the Docker profile uses make-system-tarball. 😮

Have you also booted into the resulting dvd? Maybe one our tests covers that.

You example is useful. I added it to the module itself.

@Mic92 Yes. I built a x86_64 image. It boots in the virtual machine and installs NixOS. So the CD/DVD installers are still working.