Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freetds: enable odbcSupport by default #49975

Merged
merged 1 commit into from Nov 11, 2018
Merged

freetds: enable odbcSupport by default #49975

merged 1 commit into from Nov 11, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented Nov 9, 2018

There is no reason not to, and some packages which I'm working on, requires this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@catern
freetds: enable odbcSupport by default
85d1e62 
There is no reason not to, and some packages which I'm working on,
requires this.
@infinisil
Copy link
Member

@GrahamcOfBorg build freetds

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: freetds

Partial log (click to expand)

fi
make[2]: Leaving directory '/private/tmp/nix-build-freetds-1.00.94.drv-0/freetds-1.00.94'
make[1]: Leaving directory '/private/tmp/nix-build-freetds-1.00.94.drv-0/freetds-1.00.94'
post-installation fixup
gzipping man pages under /nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94/lib  /nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94/bin
patching script interpreter paths in /nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94
/nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94/bin/osql: interpreter directive changed from " /bin/sh" to "/nix/store/n9hba031gjky8hpjgx9fnlaxhidyzxbz-bash-4.4-p23/bin/sh"
/nix/store/q3qhh832a16j7ya0v37mcixcxsiqi05f-freetds-1.00.94

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freetds

Partial log (click to expand)

shrinking /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/lib/libtdsodbc.so.0.0.0
shrinking /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/lib/libsybdb.so.5.1.0
shrinking /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/lib/libct.so.4.0.0
gzipping man pages under /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/lib  /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/bin
patching script interpreter paths in /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94
/nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94/bin/osql: interpreter directive changed from " /bin/sh" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94...
/nix/store/6019527dwzihchggvw83bxqdayqp9h9j-freetds-1.00.94

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freetds

Partial log (click to expand)

shrinking /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/bin/tsql
shrinking /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/bin/defncopy
shrinking /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/bin/tdspool
gzipping man pages under /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/lib  /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/bin
patching script interpreter paths in /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94
/nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94/bin/osql: interpreter directive changed from " /bin/sh" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94...
/nix/store/bzg6mjbz4hp710vhv1pi7lrbwl6jwsgf-freetds-1.00.94

infinisil
infinisil approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closure size is also not affected very much, 42089496 -> 43663000 bytes

@infinisil infinisil merged commit 634f980 into NixOS:master Nov 11, 2018
@catern catern deleted the freetds branch February 13, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catern @infinisil @GrahamcOfBorg