Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: 8_x -> 10_x #50003

Merged
merged 7 commits into from Nov 17, 2018
Merged

nodePackages: 8_x -> 10_x #50003

merged 7 commits into from Nov 17, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 9, 2018 •
edited

10_x is the new LTS version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from adisbladis November 9, 2018 08:52
@Mic92 Mic92 force-pushed the node-10 branch 3 times, most recently from 70ae638 to 7a10fbe Compare November 9, 2018 12:37
This was referenced Nov 9, 2018
Closed
Closed
@Mic92
Copy link
Member Author

Mic92 commented Nov 9, 2018

TODO for myself: add fkill-cli when regenerating.

@adisbladis
Copy link
Member

Great! I think we should drop any old packages where we don't receive any feedback from the pinged contributors.

@adisbladis
Copy link
Member

This is only tangential to this PR but I'm thinking that we may want to restructure our node packaging a bit.

What I want is one JSON file for all nodejs versions (node-packages.json), whichever that version may be at the time).
This is meant for popular tooling like alternative package managers and the like.

We would also have a set of version specific files (node-packages-v6.json).
These could be seen as a "staging area" for node-packages.json.

@Mic92
Copy link
Member Author

Mic92 commented Nov 14, 2018

I prepare a pull request that remove some of them.

@Mic92 Mic92 mentioned this pull request Nov 14, 2018
Merged
9 tasks
@Mic92
Copy link
Member Author

Mic92 commented Nov 14, 2018 •
edited

Not all packages I mentioned here, but those where I had a higher confidence: #50361

@Mic92 Mic92 mentioned this pull request Nov 16, 2018
Merged
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: create-cycle-app

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/jsverify failed: cache mode is 'only-if-cached' but no cached response available.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: snabbdom-to-html@^3.3.0 (node_modules/snabbdom-to-html):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/snabbdom-to-html failed: cache mode is 'only-if-cached' but no cached response available.

up to date in 1.336s
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ajn589cvvwsadn7daiqkklr698pw0464-node-create-cycle-app-5.0.0
patching script interpreter paths in /nix/store/ajn589cvvwsadn7daiqkklr698pw0464-node-create-cycle-app-5.0.0
checking for references to /build in /nix/store/ajn589cvvwsadn7daiqkklr698pw0464-node-create-cycle-app-5.0.0...
/nix/store/ajn589cvvwsadn7daiqkklr698pw0464-node-create-cycle-app-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: create-cycle-app

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/jsverify failed: cache mode is 'only-if-cached' but no cached response available.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: snabbdom-to-html@^3.3.0 (node_modules/snabbdom-to-html):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/snabbdom-to-html failed: cache mode is 'only-if-cached' but no cached response available.

audited 258 packages in 2.045s
found 0 vulnerabilities

post-installation fixup
patching script interpreter paths in /nix/store/vydk3sljm8qf3d8nl9jcxqhm4qv9qyqy-node-create-cycle-app-5.0.0
/nix/store/vydk3sljm8qf3d8nl9jcxqhm4qv9qyqy-node-create-cycle-app-5.0.0

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: create-cycle-app, sage

Partial log (click to expand)

sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/designs/orthogonal_arrays_find_recursive.pyx
    [60 tests, 12.33 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/designs/ext_rep.py
    [100 tests, 0.19 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/designs/designs_pyx.pyx
    [99 tests, 0.51 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/designs/database.py
building of '/nix/store/gmgg0yqfgsxfl4hfi77gvcqhr6is42n7-sage-tests-8.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/k9d6hncrk9sqxr8ggimnc2rv8zxrx63q-sage-8.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k9d6hncrk9sqxr8ggimnc2rv8zxrx63q-sage-8.4.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: create-cycle-app

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/ajn589cvvwsadn7daiqkklr698pw0464-node-create-cycle-app-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: create-cycle-app

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/vydk3sljm8qf3d8nl9jcxqhm4qv9qyqy-node-create-cycle-app-5.0.0

@Mic92 Mic92 merged commit b8bb863 into NixOS:master Nov 17, 2018
@Mic92 Mic92 deleted the node-10 branch November 17, 2018 00:12
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: create-cycle-app, sage

Partial log (click to expand)

    [222 tests, 1.24 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/rigged_configurations/rc_crystal.py
    [84 tests, 7.83 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/rigged_configurations/rc_infinity.py
    [114 tests, 15.24 s]
sage -t --long /nix/store/2wqxvpsn6fg2ajmpgsgmnqp2dzysfld2-sage-src-8.4/src/sage/combinat/rigged_configurations/rigged_configuration_element.py
    [280 tests, 4.76 s]
building of '/nix/store/gmgg0yqfgsxfl4hfi77gvcqhr6is42n7-sage-tests-8.4.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/k9d6hncrk9sqxr8ggimnc2rv8zxrx63q-sage-8.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/k9d6hncrk9sqxr8ggimnc2rv8zxrx63q-sage-8.4.drv' failed

gebner
gebner reviewed Nov 19, 2018
View reviewed changes
pkgs/development/node-packages/default-v10.nix
postInstall = "npm run-script prepublish";
};

phantomjs = nodePackages.phantomjs.override {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line gives me an evaluation error since we no longer have phantomjs:

 echo nodePackages | nix repl .
...
error: attribute 'phantomjs' missing, at /home/gebner/nixpkgs/pkgs/development/node-packages/default-v10.nix:71:15

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your are right, I should have not removed this one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm. Do we actually need nodePackages.phantomjs or is phantomjs enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozanmakes ozanmakes ozanmakes left review comments

@gebner gebner gebner left review comments

@rvl rvl rvl left review comments

@peterromfeldhk peterromfeldhk peterromfeldhk left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Mic92 @adisbladis @GrahamcOfBorg @ozanmakes @gebner @rvl @peterromfeldhk @screendriver @aaronjanse