Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensmtpd-extras: 5.7.1 -> 6.4.0 #50022

Merged
merged 1 commit into from Nov 12, 2018
Merged

opensmtpd-extras: 5.7.1 -> 6.4.0 #50022

merged 1 commit into from Nov 12, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Nov 9, 2018

Also use enable* flags instead of the impossible-to-discover trick of
setting to null the dependencies.

Note: I don't use these myself, so only checked that the binaries didn't fail due to linker issues: they still failed due to not being run in their expected environment / with expected flags, but I don't have a configuration using it and AFAIK we don't have any test that tests those.

Also adding myself as maintainer as I'm following OpenSMTPD closely anyway, so might as well keep OpenSMTPD-extras up-to-date and help people who have issues with it :)

cc @gebner

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ekleog
opensmtpd-extras: 5.7.1 -> 6.4.0
c9034d2 
Also use `enable*` flags instead of the impossible-to-discover trick of
setting to `null` the dependencies.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: opensmtpd-extras

Partial log (click to expand)

shrinking /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec/opensmtpd/table-passwd
shrinking /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec/opensmtpd/table-python
shrinking /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec/opensmtpd/scheduler-ram
shrinking /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-ram
shrinking /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-stub
gzipping man pages under /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0/libexec
patching script interpreter paths in /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0
checking for references to /build in /nix/store/hrpgqxvckzn4fa18aagc1ag54ayf1x8q-opensmtpd-extras-6.4.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: opensmtpd-extras

Partial log (click to expand)

shrinking /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-stub
shrinking /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-ram
shrinking /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-python
shrinking /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/libexec/opensmtpd/queue-null
gzipping man pages under /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0/libexec
patching script interpreter paths in /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0
checking for references to /build in /nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0...
/nix/store/a9663jl7g9k6nzr15gr1zp7g868qgxhr-opensmtpd-extras-6.4.0

@gebner gebner merged commit adb5b61 into NixOS:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @gebner