Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.30.0 -> 1.30.1 #50006

Merged
merged 1 commit into from Nov 14, 2018
Merged

rust: 1.30.0 -> 1.30.1 #50006

merged 1 commit into from Nov 14, 2018

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Nov 9, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

Can you change this update to point to staging?

@alyssais alyssais changed the base branch from master to staging November 12, 2018 20:18
Mic92
Mic92 reviewed Nov 12, 2018
View reviewed changes
pkgs/development/compilers/rust/bootstrap.nix
@@ -3,16 +3,16 @@
let
# Note: the version MUST be one version prior to the version we're
# building
version = "1.29.2";
version = "1.30.0";
Copy link
Member

@Mic92 Mic92 Nov 12, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc one major version? You said people from #rust told you that.

Copy link
Member

@grahamc grahamc Nov 13, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either, but I think we've been doing minor releases.

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

tested on aarch64

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

tested on x86_64.

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

@LnL7 can we get a macOS build?

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2018 •
edited

Hmm, staging is completely broken. 😕

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018 •
edited

@alyssais did you were able to build this on master with maybe one package like fd on macOS?

@alyssais
Copy link
Member Author

@Mic92 I've just cherry-picked onto current master and kicked off a build. Will report back.

@alyssais
Copy link
Member Author

I've successfully built fd on Darwin with this patch applied to master.

@Mic92 Mic92 merged commit 9e39329 into NixOS:staging Nov 14, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

It think this should be enough testing for a patch release.

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2018

My builds targeting master also succeeded, currently testing some reverts for staging so hopefully that's in a better spot soon.

@alyssais alyssais deleted the rust-1.30.1 branch November 22, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alyssais @Mic92 @LnL7 @grahamc @GrahamcOfBorg