Remove enabling of logToFile for every display manager #50033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerschtli
changed the title
|
Seems reasonable to me, though it might not hurt to mention this change in the 19.03 notes just in case? |
Gerschtli
force-pushed
the
remove/dm-log-to-file
branch
from
fbebe31
to
fafa501
Compare
|
Do you think the change in the release notes is okay? I'm not sure about my skills in the english language.. :D |
Gerschtli
force-pushed
the
remove/dm-log-to-file
branch
from
fafa501
to
4839403
Compare
|
Looking good. Given the mention in the manual I think this is pretty simple to merge into master. Just need to find someone to merge it now... |
|
The first introduction of this was in 2e088aa#diff-12d91a9ce5bfb436f1bfb642126ea347R93 (later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I don't like to log simultaneously to a file and the journal and I can't understand why
services.xserver.displayManager.job.logToFileis set totruefor these three display managers.It is inconsistent, that this option is only set for a subset of all display managers. To disable
logToFileI have to uselib.mkForcewhich is ugly because I am resetting the value to the default.Things done
I have removed all occurences of
services.xserver.displayManager.job.logToFile = true;in every display manager config.sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)