Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

up: init at 0.3.1 #50018

Merged
merged 1 commit into from Nov 11, 2018
Merged

up: init at 0.3.1 #50018

merged 1 commit into from Nov 11, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 9, 2018 •
edited

Motivation for this change

With this tool you can interactively write shell pipes with a previewed
intermediate result.

See https://github.com/akavel/up

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
up: init at 0.3.1
0045ea5 
With this tool you can interactively write shell pipes with a previewed
intermediate result.

See https://github.com/akavel/up
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: up

Partial log (click to expand)

find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
find: '/nix/store/rhiz9wh15a4f9pkn8j66l5qni38ra0i5-up-0.3.1': No such file or directory
/nix/store/r63sk6z4k3qrrc54i4nzyjma7rrq0dc2-up-0.3.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: up

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin
shrinking /nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin/bin/up
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin/bin
patching script interpreter paths in /nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin
checking for references to /build in /nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/6ms9g1cq5msn0654nd0r924mwrcr2z42-up-0.3.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: up

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin
shrinking /nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin/bin/up
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin/bin
patching script interpreter paths in /nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin
checking for references to /build in /nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/9p4gf87s54jz2f4vbls8y5sf8ma7bjqf-up-0.3.1-bin

tomberek
tomberek approved these changes Nov 10, 2018
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Linux and NixOS. Thanks!

@infinisil infinisil merged commit 32cbcbf into NixOS:master Nov 11, 2018
@Ma27 Ma27 deleted the init-up branch November 11, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @GrahamcOfBorg @tomberek @infinisil