-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
php: 7.2.11 -> 7.2.12 #50014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: 7.2.11 -> 7.2.12 #50014
Conversation
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/php/versions
@@ -227,7 +227,7 @@ in { | |||
# We can't update the darwin versions because they simply don't compile at | |||
# all due to a bug in the intl extensions. | |||
# | |||
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.11. | |||
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryantm This change was probably not intended 😄
But from the changelog of 7.2.12 I haven't seen that they would have fixed the bug with darwin and the upstream issue isn't closed. So we can probably just add 7.2.12 to this list.
I haven't tested building 7.2.12 on darwin though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, nixpkgs-update is kind of dumb about updating version strings. I don't think I can make it much better until I parse nixpkgs to find the version location.
Success on x86_64-darwin (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
@@ -227,7 +227,7 @@ in { | |||
# We can't update the darwin versions because they simply don't compile at | |||
# all due to a bug in the intl extensions. | |||
# | |||
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.11. | |||
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.12. | |
# The bug so far is present in 7.1.21, 7.1.22, 7.1.23, 7.2.9, 7.2.10, 7.2.11. |
@ryantm can you accept this proposed change? Then it creates a new commit that needs to be squasched when merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add 7.2.12 to the list of broken versions and not just revert that line.
Co-Authored-By: r-ryantm <ryantm-bot@ryantm.com>
Success on x86_64-darwin (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: php Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: php Partial log (click to expand)
|
@adisbladis Can you close this PR for me? It's not needed anymore. |
Superseded by #51091 |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/php/versions.
meta.description for php is: '"An HTML-embedded scripting language"'.
Checks done (click to expand)
Outpath report (click to expand)
Outpath difference report
103 total rebuild paths
71 package rebuilds
71 x86_64-linux rebuilds
16 i686-linux rebuilds
0 x86_64-darwin rebuilds
16 aarch64-linux rebuilds
First ten rebuilds by attrpath
arcanist
drush
hhvm
kcachegrind
kdeApplications.kcachegrind
limesurvey
lsp-plugins
matomo
nagios
nextcloud-news-updater
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @globin @etu for testing.