PICARD-1437: Fix any deleted tags in new metadata mark file as changed #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saved files showed up as changed after release reload
Problem
When saving a file and reloading the matched release Picard 2.1.0dev2 will show the file as changed again. Previous versions showed a checkmark icon in this case.
Solution
The cause was the check for any deleted tags in
new_metadata: Usually empty values innew_metadataare ignored on comparison, since the will be filled with original metadata value. But the check introduced with #1035 also considered the tag changed if it was empty andnew_metadatacontained any deleted tags.Fixed this by checking only if the currently tested tag is marked as deleted in
new_metadataAction