Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: fix cross -> inherit devdoc from native build #51824

Merged
merged 1 commit into from Dec 10, 2018
Merged

glib: fix cross -> inherit devdoc from native build #51824

merged 1 commit into from Dec 10, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 10, 2018 •
edited

Glib uses gobject introspection to generate documentation.
If we would want to cross-compile those, we would need native binaries
from the previous build stage. Instead we can simply just copy over
the generated documentation.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
glib: fix cross -> inherit devdoc from native build
efa57f8 
Glib uses gobject introspection to generate documentation.
If we would want to cross-compile those, we would need native binaries
from the previous build stage. Instead we can simply just copy over
the generated documentation.
@Mic92
Copy link
Member Author

Mic92 commented Dec 10, 2018

@GrahamcOfBorg build glib pkgsCross.aarch64-multiplatform.glib

@Mic92 Mic92 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Dec 10, 2018
@Mic92 Mic92 merged commit 01e6a04 into NixOS:staging Dec 10, 2018
@Mic92 Mic92 deleted the cross-glib branch December 10, 2018 13:30
@jtojnar jtojnar mentioned this pull request Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg