Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] gnss-sdr: turn off unit tests explicitly #51826

Merged
merged 1 commit into from Dec 10, 2018
Merged

[18.09] gnss-sdr: turn off unit tests explicitly #51826

merged 1 commit into from Dec 10, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

This unbreaks the build on 18.09. Already fixed on master. The commit that broke build was cherry-picked from master earlier (ff43959)

Things done

(cherry picked from commit 0528001)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b merged commit dc75482 into NixOS:release-18.09 Dec 10, 2018
@markuskowa markuskowa deleted the fix-gnss-sdr-18.09 branch December 10, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @c0bw3b @GrahamcOfBorg