PICARD-1439: Unify filename generation by metadata script #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce script_to_filename to be used by both file and cover art naming.
zas
requested changes
Dec 10, 2018
zas
requested changes
Dec 11, 2018
zas
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
As reported on the forums new line characters in cover art naming can cause file saving errors. Actually the cover art file name generation uses code derived from the file naming, but the file naming code has some fixes for edge cases that never got implemented for cover art.
Solution
Introduce script_to_filename to be used by both file and cover art naming. This:
Action