New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nvidia: fix inverted assertion #51836
Conversation
Should also backport to 18.09. |
The bug was introduced in 4ef8233 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm amazed how long this has gone unnoticed.
(cherry picked from commit ac19d5e)
If I interpret this correctly, if
|
|
The problem is I haven't touched any configuration regarding gdm ( Currently using lightdm as my display manager. |
Oh, right, I didn't realize... that you haven't enabled gdm. I'll fix it straight away. |
Can verify that the assertion works for me based off the current master, thanks! |
Motivation for this change
I can't turn off wayland, because my video drivers demand that wayland is enabled, because they don't support wayland.
This will cause all gdm+nvidia users to have to add the following to their config. Is there a way we can avoid this? Though as I understand it, gdm+nvidia is unable to start sessions (at least I saw this on 18.09), so there probably aren't any users.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)