python: add geographiclib and update geopy #51839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Dec 11, 2018
| @@ -11,7 +11,7 @@ | |||
| buildPythonPackage rec { | |||
| pname = "geopy"; | |||
| version = "1.18.0"; | |||
| disabled = !isPy27; | |||
| disabled = false; | |||
There was a problem hiding this comment.
Maybe just remove the line completely?
dotlambda
requested changes
Dec 11, 2018
| buildPythonPackage rec { | ||
| pname = "geographiclib"; | ||
| version = "1.49"; | ||
| disabled = false; |
There was a problem hiding this comment.
Suggested change
| disabled = false; |
| sha256 = "635da648fce80a57b81b28875d103dacf7deb12a3f5f7387ba7d39c51e096533"; | ||
| }; | ||
|
|
||
| doCheck = false; # too much |
There was a problem hiding this comment.
Too much what? Please add a meaningful comment
There was a problem hiding this comment.
This was copy-pasted from geopy package. It probably shouldn't belong in this newly created file.
| doCheck = false; # too much | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://geographiclib.sourceforge.io"; |
There was a problem hiding this comment.
Suggested change
| homepage = "https://geographiclib.sourceforge.io"; | |
| homepage = https://geographiclib.sourceforge.io; |
dotlambda
requested changes
Dec 11, 2018
|
Nothing happening so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
my first nixpkgs PR. Let me know if something should be different.
(1) added geographiclib from pip.
(2) updated geopy from 1.11 -> 1.18
(3) enabled python3 support for geopy
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)