Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyjet: fix for python37 #51841

Merged
merged 1 commit into from Dec 21, 2018
Merged

pythonPackages.pyjet: fix for python37 #51841

merged 1 commit into from Dec 21, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 10, 2018

Motivation for this change

python37 breaks old API, cython files need to be regenerated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Upstream issue scikit-hep/pyjet#8

@veprbl veprbl requested a review from FRidh as a code owner December 10, 2018 18:45
@veprbl
Copy link
Member Author

veprbl commented Dec 10, 2018

@GrahamcOfBorg build python27Packages.pyjet python37Packages.pyjet

@veprbl
Copy link
Member Author

veprbl commented Dec 10, 2018

@GrahamcOfBorg build python27Packages.pyjet python37Packages.pyjet

@veprbl veprbl merged commit 284df60 into NixOS:master Dec 21, 2018
@veprbl veprbl deleted the pr/pyjet_fix branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg