Add non-bogus completion times to GitHub checks #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
Dec 10, 2018
| CheckRunOptions { | ||
| name: "nix-build -A bar -A foo --argstr system x86_64-linux".to_string(), | ||
| actions: None, | ||
| started_at: None, | ||
| completed_at: Some("2018-01-01T01:01:01Z".to_string()), | ||
| completed_at: Some("2018-04-20T13:37:42Z".to_string()), |
grahamc
reviewed
Dec 10, 2018
| @@ -138,7 +139,7 @@ fn result_to_check(result: &LegacyBuildResult) -> CheckRunOptions { | |||
| result.system | |||
| ), | |||
| actions: None, | |||
| completed_at: Some("2018-01-01T01:01:01Z".to_string()), | |||
| completed_at: Some(timestamp.to_rfc3339()), | |||
There was a problem hiding this comment.
Seems chrono isn't emitting Z but instead completed_at: Some("2018-04-20T13:37:42+00:00") and thus each of these tests are failing. We'd need to use (and probably should?) https://docs.rs/chrono/0.4.6/chrono/struct.DateTime.html#method.to_rfc3339_opts with use_z set to True for it to retain the same format, like this:
assert_eq!(dt.to_rfc3339_opts(SecondsFormat::Secs, true),
"2018-01-26T18:30:09Z");
There was a problem hiding this comment.
Note I specifically prefer using the Z format and not changing the output format, since we know that specific format works and not changing the output here makes it a much safer change. Despite iso8601 being a "standard" who knows how much of it they follow.
This should eventually be replaced with completion times from the builders, but they don't currently provide that information
|
Nice! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should eventually be replaced with completion times from the builders, but they don't currently provide that information, so local time will have to do.