Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix someone getting powned trough bad docs #51840

Merged
merged 1 commit into from Dec 11, 2018
Merged

Fix someone getting powned trough bad docs #51840

merged 1 commit into from Dec 11, 2018

Conversation

jappeace
Copy link
Contributor

Motivation for this change

security

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Dec 11, 2018 •
edited

Thanks for the fix — good spot. Would you mind amending your commit so that it follows our standard format? Start it with doc: or nixos/nginx: . I think it’s good to keep the first line of the commit message to fifty characters or less too. Thanks!

@Mic92 Mic92 merged commit e576c3b into NixOS:master Dec 11, 2018
Mic92 pushed a commit that referenced this pull request Dec 11, 2018
@jappeace @Mic92
doc: Fix insecure nginx docs (#51840)
32d7eb3 
(cherry picked from commit e576c3b)
@Mic92
Copy link
Member

Mic92 commented Dec 11, 2018

backport in 32d7eb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jappeace @alyssais @Mic92 @c0bw3b @GrahamcOfBorg @Janik-Haag