Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{easyrpg-player,liblcf}: 0.5.3 -> 0.5.4 #50429

Merged
merged 2 commits into from Nov 15, 2018
Merged

{easyrpg-player,liblcf}: 0.5.3 -> 0.5.4 #50429

merged 2 commits into from Nov 15, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 15, 2018 •
edited

Motivation for this change

Closes #50061 (liblcf and easyrpg-player needs to be updated together)
expat and icu are now propagatedBuildInputs of liblcf because easyrpg-player needs it
+ added short descriptions to both packages

/cc @yegortimoshenko

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b mentioned this pull request Nov 15, 2018
Closed
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: easyrpg-player, liblcf

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4
shrinking /nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4/bin/easyrpg-player
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4/bin
patching script interpreter paths in /nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4
checking for references to /build in /nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4...
/nix/store/vanmc8k2a5n0c0bn2jx7lbcnh2irpwqk-easyrpg-player-0.5.4
/nix/store/s1sk8r9mqkhbf5sgazph6amw0hh1xpyx-liblcf-0.5.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: easyrpg-player, liblcf

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4
shrinking /nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4/bin/easyrpg-player
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4/bin
patching script interpreter paths in /nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4
checking for references to /build in /nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4...
/nix/store/q6h7y6pdwk08cpww5z45zjh2mm3naspc-easyrpg-player-0.5.4
/nix/store/chf3nyz30xm99m7kcawb05li3p3ajlzx-liblcf-0.5.4

@c0bw3b c0bw3b merged commit d554f80 into NixOS:master Nov 15, 2018
@c0bw3b c0bw3b deleted the pkg/easyrpg branch November 16, 2018 22:38
@lukateras
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0bw3b @GrahamcOfBorg @lukateras @r-ryantm