Skip to content

makemkv: 1.14.0 -> 1.14.1 #50437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

makemkv: 1.14.0 -> 1.14.1 #50437

wants to merge 1 commit into from
+3 −3

Conversation

neilmayhew
Copy link
Member

Motivation for this change

The tarball for 1.14.0 has gone

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@neilmayhew
makemkv: 1.14.0 -> 1.14.1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
infinisil Silvan Mosberger
GPG key ID: E8F1E9EAD284E17D
Expired
Verified
Learn about vigilant mode
3e9e22e
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 16, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 16, 2018

@GrahamcOfBorg build makemkv

It seems old sources are moved to:

http://www.makemkv.com/download/old/makemkv-bin-${version}.tar.gz
http://www.makemkv.com/download/old/makemkv-oss-${version}.tar.gz

I wonder if we should set those as fallback URLs to avoid a failure at every upstream bump

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: makemkv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: makemkv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 16, 2018

Woops it's unfree >;<

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2018

Yes, a mirror would help in future.

c0bw3b
c0bw3b requested changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested rebuilding v1.14.0 with the suggested URL changes and it succeeded (404 on the first url then fetchurl tries the second one).
It will prevent failure on the next release.

pkgs/applications/video/makemkv/default.nix
@@ -4,17 +4,17 @@

stdenv.mkDerivation rec {
name = "makemkv-${ver}";
ver = "1.14.0";
ver = "1.14.1";
builder = ./builder.sh;

src_bin = fetchurl {
url = "http://www.makemkv.com/download/makemkv-bin-${ver}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "http://www.makemkv.com/download/makemkv-bin-${ver}.tar.gz";
urls = [
"http://www.makemkv.com/download/makemkv-bin-${ver}.tar.gz"
"http://www.makemkv.com/download/old/makemkv-bin-${ver}.tar.gz"
];

pkgs/applications/video/makemkv/default.nix
builder = ./builder.sh;

src_bin = fetchurl {
url = "http://www.makemkv.com/download/makemkv-bin-${ver}.tar.gz";
sha256 = "1xm5pww6jf3m704y7d7nc2ni2a6ygxwb2c665agg2i059sppwz1f";
sha256 = "1n4gjb1531gkvnjzipw63v3zdxmrq5nai9nn6m2ix3lskksjrrhp";
};

src_oss = fetchurl {
url = "http://www.makemkv.com/download/makemkv-oss-${ver}.tar.gz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "http://www.makemkv.com/download/makemkv-oss-${ver}.tar.gz";
urls = [
"http://www.makemkv.com/download/makemkv-oss-${ver}.tar.gz"
"http://www.makemkv.com/download/old/makemkv-oss-${ver}.tar.gz"
];

nyanloutre added a commit to nyanloutre/nixpkgs that referenced this pull request Nov 20, 2018
@nyanloutre
makemkv: using two URLs for src
05166dc 
This will prevent future failures due to the first URL being broken each
time a new version is released

See NixOS#50437 (comment)
for details
nyanloutre added a commit to nyanloutre/nixpkgs that referenced this pull request Nov 20, 2018
@nyanloutre
makemkv: using two URLs for src
e24bc96 
This will prevent future failures due to the first URL being broken each
time a new version is released

See NixOS#50437 (comment)
for details

(cherry picked from commit 05166dc)
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 20, 2018

Closing after #50696 got merged

@c0bw3b c0bw3b closed this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neilmayhew @c0bw3b @GrahamcOfBorg @Mic92