Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cython: don't test codestyle #50432

Merged
merged 1 commit into from Nov 16, 2018
Merged

pythonPackages.cython: don't test codestyle #50432

merged 1 commit into from Nov 16, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 15, 2018

Motivation for this change

When I did the 0.29 upgrade, I forgot to test python3. cython fails the tests on python3 because it tests the code style by default. It needs pycodestyle for that. When adding the pycodestyle dependencies the relevant tests fail. Since there is no reason to test code style on distro CI, I'm just disabling the tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner November 15, 2018 22:22
@timokau
pythonPackages.cython: don't test codestyle
f1b70c9 
This requires pycodestyle when using python3 and adding it leads to test
failures for some reason. Maybe some patching we do. There is no reason to
test codestyle for a distro, so just disable it.
@timokau timokau merged commit d53c0a7 into NixOS:staging Nov 16, 2018
@timokau timokau deleted the cython-py3-fix branch November 16, 2018 08:21
FRidh pushed a commit that referenced this pull request Nov 18, 2018
@timokau @FRidh
pythonPackages.cython: don't test codestyle (#50432)
3aa6b8c 
This requires pycodestyle when using python3 and adding it leads to test
failures for some reason. Maybe some patching we do. There is no reason to
test codestyle for a distro, so just disable it.
@FRidh
Copy link
Member

FRidh commented Nov 18, 2018

cherry-picked to staging-next because it was needed there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @FRidh @Mic92 @GrahamcOfBorg