Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procdump: init at 1.0.1 #50435

Merged
merged 1 commit into from Nov 17, 2018
Merged

procdump: init at 1.0.1 #50435

merged 1 commit into from Nov 17, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 15, 2018

Motivation for this change

Resolves #49771
/cc @colemickens

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: procdump

Partial log (click to expand)

cp procdump.1 /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1
shrinking /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1/bin/procdump
gzipping man pages under /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1/bin
patching script interpreter paths in /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1
checking for references to /build in /nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1...
/nix/store/gnkvd65ss5zkrs9zahfdv9gdqhcbykzi-procdump-1.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: procdump

Partial log (click to expand)

cp procdump.1 /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1
shrinking /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1/bin/procdump
gzipping man pages under /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1/bin
patching script interpreter paths in /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1
checking for references to /build in /nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1...
/nix/store/jlnwnki4mzpsg5jnf7civ8kfmz6lzkv6-procdump-1.0.1

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018 

$ sudo procdump -s 1 -M 1 -p4322

ProcDump v1.0.1 - Sysinternals process dump utility
Copyright (C) 2017 Microsoft Corporation. All rights reserved. Licensed under the MIT license.
Mark Russinovich, Mario Hewardt, John Salem, Javid Habibi
Monitors a process and writes a dump file when the process exceeds the
specified criteria.

Process:                firefox (4322)
CPU Threshold:          n/a
Commit Threshold:       >=1
Threshold Seconds:      1
Number of Dumps:        1

Press Ctrl-C to end monitoring without terminating the process.

[23:18:06 - INFO]: Commit: 299 MB

where are those stored?

@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2018 •
edited

LGTM! 🎉

Whoops needs some fixes, will update soon.

@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2018

Consider this commit/these changes: dtzWill@a83ee40

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 16, 2018

Thanks @dtzWill I will look into it later today.
The sigset name conflict is only with musl, right? In which case I agree it should be patched upstream.

@Mic92
Copy link
Member

Mic92 commented Nov 16, 2018

yes. upstream should merge this quickly.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 16, 2018

where are those stored?

In the current working dir (now that it really works)

$ sudo procdump -s 1 -M 1 -p 721

ProcDump v1.0.1 - Sysinternals process dump utility
Copyright (C) 2017 Microsoft Corporation. All rights reserved. Licensed under the MIT license.
Mark Russinovich, Mario Hewardt, John Salem, Javid Habibi
Monitors a process and writes a dump file when the process exceeds the
specified criteria.

Process:                nscd (721)
CPU Threshold:          n/a
Commit Threshold:       >=1
Threshold Seconds:      1
Number of Dumps:        1

Press Ctrl-C to end monitoring without terminating the process.

[12:47:26 - INFO]: Commit: 2 MB
[12:47:28 - INFO]: Core dump 1 generated: nscd_commit_2018-11-16_12:47:26.721

$ ll nscd_commit_2018-11-16_12\:47\:26.721 
-rw-r--r-- 1 root root 453609880 16 nov.  12:47 nscd_commit_2018-11-16_12:47:26.721

@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2018

Submitted sigset fix upstream: Sysinternals/ProcDump-for-Linux#50 if you don't mind including :).

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: procdump

Partial log (click to expand)

cp procdump.1 /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1
shrinking /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1/bin/procdump
gzipping man pages under /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1/bin
patching script interpreter paths in /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1
checking for references to /build in /nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1...
/nix/store/mlhhiw7d3h0dl1rrb41lrbwmfhidl4va-procdump-1.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: procdump

Partial log (click to expand)

cp procdump.1 /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1/share/man/man1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1
shrinking /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1/bin/procdump
gzipping man pages under /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1/bin
patching script interpreter paths in /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1
checking for references to /build in /nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1...
/nix/store/cgngs95ri198ip74iqphf1gmxfmri1bp-procdump-1.0.1

@c0bw3b c0bw3b merged commit c102306 into NixOS:master Nov 17, 2018
@c0bw3b c0bw3b deleted the pkg/procdump branch November 17, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0bw3b @GrahamcOfBorg @Mic92 @dtzWill