fix import cycle #1046
fix import cycle #1046
Conversation
I was too confident this would have been catched by the unittests, but as I learned most of those are require configured backends. This time I used this nixops version to deploy my server.
| PYTHONPATH= mypy --cache-dir=/dev/null nixops | ||
| # smoke test | ||
| HOME=$TMPDIR $out/bin/nixops --version |
There was a problem hiding this comment.
Hopefully this catches more import errors then the current tests.
|
I have seen this failing before: |
| @@ -1269,7 +1270,7 @@ def _create_state(depl, type, name, id): | |||
| def _load_modules_from(dir): | |||
| for module in os.listdir(os.path.dirname(__file__) + "/" + dir): | |||
| if module[-3:] != '.py' or module == "__init__.py": continue | |||
| __import__("nixops." + dir + "." + module[:-3], globals(), locals()) | |||
| importlib.import_module("nixops." + dir + "." + module[:-3]) | |||
There was a problem hiding this comment.
mhm, this did not solve the problem.
There was a problem hiding this comment.
I would recommend importlib over __import__. Since the latter one does not guarantee portability across python versions:
https://docs.python.org/3/library/importlib.html#introduction
There was a problem hiding this comment.
|
Ok. Now I blame build impurities! https://travis-ci.com/NixOS/nixops/builds/91563105#L4414 |
Mic92
force-pushed
the
fix-import-cycle
branch
from
5bb4f89 to
b8811ce
Compare
|
Should probably enable sandboxing for travis-ci. |
|
I will look into that. |
|
The question is how conservative travis is in this regard, if we ask them to switch this on by default. I guess we could have an option for that. |
|
Could expose the option to |
Mic92
force-pushed
the
fix-import-cycle
branch
2 times, most recently
from
721a5e7 to
7ecb5b2
Compare
importlibs is wrapper around __import and harder to misuse.
Mic92
force-pushed
the
fix-import-cycle
branch
2 times, most recently
from
9d35184 to
4b75633
Compare
|
Ok. The mess is cleaned up. I have documented the sandbox feature in our wiki: https://nixos.wiki/wiki/Nix_on_Travis |
Mic92
force-pushed
the
fix-import-cycle
branch
from
4b75633 to
eb86e16
Compare
I was too confident this would have been catched by the unittests,
but as I learned most of those require configured backends.
This time I used this nixops version to deploy my server.
cc @domenkozar sorry for bothering you again.