Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.8.25p1 -> 1.8.26 #50422

Merged
merged 1 commit into from Nov 16, 2018
Merged

sudo: 1.8.25p1 -> 1.8.26 #50422

merged 1 commit into from Nov 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 15, 2018 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the title ###### Motivation for this change sudo: 1.8.25p1 -> 1.8.26 Nov 15, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Nov 15, 2018

@GrahamcOfBorg test sudo

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.sudo

Partial log (click to expand)

error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:27:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/lists.nix:113:41, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/lib/attrsets.nix:347:46:
while evaluating the attribute 'sudo' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:194:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:194:10:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/q5sxwfi970znmldfnxly848v8m4ki2zx-rbvermaa-spot' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.sudo

Partial log (click to expand)

Cannot nix-instantiate `tests.sudo' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/lib/attrsets.nix:347:27:
while evaluating the attribute 'sudo' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/nixos/tests/all-tests.nix:194:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/nixos/tests/all-tests.nix:194:10:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/nix-test-rs-29/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-29/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/60pbzqp65mnqwxx2ri76871rjx4w9dcx-grahamc-aarch64-community-29' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/bin/sudoreplay
shrinking /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/bin/sudo
shrinking /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/bin/cvtsudoers
gzipping man pages under /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/share/man/
strip is /nix/store/cr415sky7bmrpyp63adqhaaslj83b15w-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/libexec  /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/bin  /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/sbin
patching script interpreter paths in /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26
checking for references to /build in /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26...
moving /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/sbin/* to /nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26/bin
/nix/store/9g2i6iccw3z5w7gpkfxmlkq9q27gn5mx-sudo-1.8.26

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sudo

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sudo

Partial log (click to expand)

shrinking /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/libexec/sudo/sudoers.so
shrinking /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/libexec/sudo/group_file.so
shrinking /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/libexec/sudo/libsudo_util.so.0.0.0
gzipping man pages under /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/share/man/
strip is /nix/store/s2azzxwmnjql93c8xwrdhp48xrmki1yz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/libexec  /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/bin  /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/sbin
patching script interpreter paths in /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26
checking for references to /build in /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26...
moving /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/sbin/* to /nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26/bin
/nix/store/n0inzkdjj41fb1my53k348lqz7xckpl8-sudo-1.8.26

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 16, 2018

Bugfix release:
https://www.sudo.ws/stable.html#1.8.26

@zimbatm zimbatm merged commit 0a085d5 into NixOS:staging Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @c0bw3b @zimbatm