Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages: drop all packages and package versions for PHP5 #50420

Merged
merged 1 commit into from Nov 21, 2018
Merged

phpPackages: drop all packages and package versions for PHP5 #50420

merged 1 commit into from Nov 21, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 15, 2018 •
edited

Motivation for this change

PHP5 will be EOLed by the end of the year: https://secure.php.net/supported-versions.php

In fact we don't support PHP5 anymore since 7e6b76f.

The following packages had older versions packaged as well to retain
PHP5 support:

  • APCu (4.0.11)
  • Memcached (2.2.0), Memcache (3.0.8)
  • XDebug (2.3.1)
  • YAML (1.3.1)
  • pthreads (2.0.10)
  • redis (2.2.7)

The following packages were removed entirely due to missing support for
PHP7:

  • spidermonkey
  • zendopcache (part of PHP itself since 5.5)
  • xcache
  • geoip

Furthermore I declared phpPackages.pthreads as broken for now as it
supports PHP7, but the last release was 2016 and therefore PHP 7.0 is
supported, but the build fails with PHP 7.1 and PHP 7.2 (https://pecl.php.net/package/pthreads).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Nov 15, 2018

note: I built most of the packages except phpPackages.oci8 as it requires me to have an Oracle account to manually download the sources which I don't have (and don't intend to create being honestly).

@Mic92
Copy link
Member

Mic92 commented Nov 15, 2018

@flokli interested in testing? phpPackages.oci8

@aanderse
Copy link
Member

aanderse commented Nov 16, 2018 •
edited

@flokli interested in testing? phpPackages.oci8

I am unable to actually test this against an oracle database until Monday, but I was able to successfully build both the php 7.1 and 7.2 version of this.

Feel free to ping me any time you need oci8 tested as I have developers who will be using this at work.

@flokli
Copy link
Contributor

flokli commented Nov 18, 2018

@Mic92 I didn't use this package (except also successfully being able to compile it), only the python binding.

If @aanderse could have a look at the php one tomorrow, that would be great :-)

@Ma27 can you rebase in the meantime?

@Ma27
phpPackages: drop all packages and package versions for PHP5
24b7bdb 
PHP5 will be EOLed by the end of the year: https://secure.php.net/supported-versions.php

In fact we don't support PHP5 anymore since 7e6b76f.

The following packages had older versions packaged as well to retain
PHP5 support:

* APCu (4.0.11)
* Memcached (2.2.0), Memcache (3.0.8)
* XDebug (2.3.1)
* YAML (1.3.1)
* pthreads (2.0.10)
* redis (2.2.7)

The following packages were removed entirely due to missing support for
PHP7:

* spidermonkey
* zendopcache (part of PHP itself since 5.5)
* xcache
* geoip

Furthermore I declared `phpPackages.pthreads` as broken for now as it
supports PHP7, but the last release was 2016 and therefore PHP 7.0 is
supported, but the build fails with PHP 7.1 and PHP 7.2 (https://pecl.php.net/package/pthreads).
@Ma27
Copy link
Member Author

Ma27 commented Nov 18, 2018

fixed, rebased and tested apcu and apcu_bc packages

@aanderse
Copy link
Member

I've gone ahead and confirmed that connecting to databases+running a few queries is functioning as expected, so all good from my perspective.

@Ma27
Copy link
Member Author

Ma27 commented Nov 19, 2018

@Mic92 this should be mergable then, correct?

@Ma27
Copy link
Member Author

Ma27 commented Nov 21, 2018

I'm assuming the three approvals including approvals of PHP on NIx users should be sufficient.
In the end this isn't breaking anybody's setup, PHP5 support was explicitly dropped previously and this was mostly dead code :)

@Ma27 Ma27 merged commit 1151c6a into NixOS:master Nov 21, 2018
@Ma27 Ma27 deleted the cleanup-php-pkgs branch November 21, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@etu etu etu approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ma27 @Mic92 @aanderse @flokli @etu @GrahamcOfBorg