fltrator : init at 2.3 #52021
Merged
fltrator : init at 2.3 #52021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srhb
requested changes
Dec 14, 2018
marius851000
force-pushed
the
fltrator
branch
from
234fb04
to
13a82a6
Compare
srhb
reviewed
Dec 14, 2018
srhb
reviewed
Dec 14, 2018
jtojnar
requested changes
Dec 14, 2018
marius851000
force-pushed
the
fltrator
branch
from
3c75038
to
0c1aeda
Compare
jtojnar
reviewed
Dec 14, 2018
marius851000
force-pushed
the
fltrator
branch
from
0c1aeda
to
25de03f
Compare
|
Didn't know what I've done with git, nor how to solve it. |
jtojnar
reviewed
Dec 16, 2018
|
I would try Then add, commit, and force push. |
marius851000
force-pushed
the
fltrator
branch
from
39a4155
to
d748214
Compare
marius851000
force-pushed
the
fltrator
branch
2 times, most recently
from
39a4155
to
17ea258
Compare
fltrator : added patch to made fltrator-landscape use the correct data directory. fltrator : corrected an error with meta fltrator : enhancement based on srhb suggestion fltrator : add .desktop fltrator : enanced the build file, based on suggestion of jtojnar & srhb fltrator : use nativeBuildInput rather that buildInputs. suggested by jtojnar fltrator : desktop file is now pointing to the specific binary, and has icon. fltrator : deleted the manual unpack phase
marius851000
force-pushed
the
fltrator
branch
from
1ccff21
to
5eb428e
Compare
|
@marius851000 ping |
|
It appear to be good for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to learn how to make a nix package. I've picked a random ( apparently simple ) open source game from libregamewiki, and make a package.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"- no package depend on itTested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.