Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.29.1 -> 1.30.0 #52036

Merged
merged 1 commit into from Dec 14, 2018
Merged

vscode: 1.29.1 -> 1.30.0 #52036

merged 1 commit into from Dec 14, 2018

Conversation

the-kenny
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified all hashes are correct, and I've built and executed this successfully on NixOS.

@worldofpeace
Copy link
Contributor

Changelog for those interested.

@worldofpeace
Copy link
Contributor

Additionally I recall discussing that updates to vscode should be backported to stable here.

I will submit that soon.

@worldofpeace worldofpeace merged commit 38d4c09 into NixOS:master Dec 14, 2018
@worldofpeace worldofpeace mentioned this pull request Dec 14, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@the-kenny @worldofpeace @GrahamcOfBorg