Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgit2: drop 0.26 #52068

Merged
merged 4 commits into from Dec 16, 2018
Merged

libgit2: drop 0.26 #52068

merged 4 commits into from Dec 16, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 14, 2018 •
edited

Motivation for this change

Follow-up on #44137

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dtzWill

@jtojnar jtojnar requested a review from FRidh as a code owner December 14, 2018 15:40
@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 14, 2018

@GrahamcOfBorg build libgit2-glib subsurface gnome-builder stagit haskellPackages.hlibgit2 gitg gitAndTools.grv pythonPackages.pygit2

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 14, 2018

Need to check if #51416 still applies

@jtojnar jtojnar changed the base branch from master to staging December 15, 2018 07:53
@jtojnar jtojnar changed the base branch from staging to master December 15, 2018 07:55
@jtojnar jtojnar merged commit 5dac5e1 into NixOS:staging Dec 16, 2018
@jtojnar jtojnar deleted the libglib2-0.27 branch December 16, 2018 22:22
@grahamc
Copy link
Member

grahamc commented Jan 11, 2019

10b50b6...ac97ba2

@grahamc
Copy link
Member

grahamc commented Jan 11, 2019

Part of this PR was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @grahamc @GrahamcOfBorg