Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lz4: Fix pkgsStatic build for 18.09 #51969

Merged
merged 1 commit into from Dec 13, 2018
Merged

lz4: Fix pkgsStatic build for 18.09 #51969

merged 1 commit into from Dec 13, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Dec 13, 2018 •
edited

Motivation for this change

Backport of #51965.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar changed the title lz4: fix pkgsStatic build lz4: fix pkgsStatic build for 18.09 Dec 13, 2018
@Ericson2314 Ericson2314 changed the title lz4: fix pkgsStatic build for 18.09 lz4: Fix pkgsStatic build for 18.09 Dec 13, 2018
@Ericson2314 Ericson2314 mentioned this pull request Dec 13, 2018
Merged
10 tasks
@Ericson2314 Ericson2314 merged commit 340c0c4 into NixOS:release-18.09 Dec 13, 2018
@vaibhavsagar vaibhavsagar deleted the fix-static-lz4 branch December 14, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @Ericson2314 @GrahamcOfBorg