Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: 1.11.2 -> 1.11.4, 1.10.3 -> 1.10.7 [CVE-2018-16873, CVE-2018-16874, CVE-2018-16875] #52049

Merged
merged 2 commits into from Dec 17, 2018
Merged

go: 1.11.2 -> 1.11.4, 1.10.3 -> 1.10.7 [CVE-2018-16873, CVE-2018-16874, CVE-2018-16875] #52049

merged 2 commits into from Dec 17, 2018

Conversation

ben0x539
Copy link
Contributor

@ben0x539 ben0x539 commented Dec 14, 2018 •
edited

Motivation for this change

https://groups.google.com/forum/#!msg/golang-announce/Kw31K8G7Fi0/z2olKn-QCAAJ "We have just released Go 1.11.3 and Go 1.10.6 to address three recently reported security issues."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ben0x539
Copy link
Contributor Author

I've been advised to make this a pull request against staging instead, and also go 1.11.4 and 1.10.7 have been released by now.

@ben0x539 ben0x539 changed the base branch from master to staging December 15, 2018 14:55
@ben0x539 ben0x539 changed the title go: 1.11.2 -> 1.11.3, 1.10.3 -> 1.10.6 go: 1.11.2 -> 1.11.4, 1.10.3 -> 1.10.7 Dec 15, 2018
@edef1c edef1c changed the title go: 1.11.2 -> 1.11.4, 1.10.3 -> 1.10.7 go: 1.11.2 -> 1.11.4, 1.10.3 -> 1.10.7 [CVE-2018-16873, CVE-2018-16874, CVE-2018-16875] Dec 16, 2018
@fpletz fpletz merged commit 515a0f5 into NixOS:staging Dec 17, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 17, 2018

@fpletz did you backport to release-18.09? I think you can skip staging-18.09 for go stuff. It builds fast enough.

@fpletz
Copy link
Member

fpletz commented Dec 17, 2018

@Mic92 Not yet, I was waiting for some test builds of go packages on 18.09 to finish before pushing. Will do.

@ben0x539 ben0x539 deleted the go1.11.3 branch December 17, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ben0x539 @Mic92 @fpletz @GrahamcOfBorg