Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gmsh: 4.0.5 -> 4.0.7 #52042

Merged
merged 1 commit into from Dec 14, 2018
Merged

gmsh: 4.0.5 -> 4.0.7 #52042

merged 1 commit into from Dec 14, 2018

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Dec 14, 2018

Motivation for this change

Keeping 3rd party dependencies for FreeCAD up to date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

https://gitlab.onelab.info/gmsh/gmsh/blob/master/CHANGELOG.txt

@markuskowa
Copy link
Member

@GrahamcOfBorg build gmsh

@markuskowa
Copy link
Member

Keeping 3rd party dependencies for FreeCAD up to date

As far as I can see, gmsh is not an input of freecad.

When I tried to test the GUI it complains that it can not find opencascade (which is not an input of gmsh). Is there maybe a dependency not properly defined?

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 14, 2018 •
edited

Keeping 3rd party dependencies for FreeCAD up to date

As far as I can see, gmsh is not an input of freecad.

It is required if you want to run the Finite Element Material Workbench

@markuskowa markuskowa merged commit 654dd5c into NixOS:master Dec 14, 2018
@luzpaz luzpaz deleted the gmsh-4-0-7 branch December 14, 2018 23:46
@luzpaz luzpaz mentioned this pull request Dec 18, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luzpaz @markuskowa @GrahamcOfBorg