New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.markdown: 2.6.10 -> 3.0.1 #52058
pythonPackages.markdown: 2.6.10 -> 3.0.1 #52058
Conversation
ccb49a4
to
42e51cf
Compare
@GrahamcOfBorg build pythonPackages.markdown |
I tried running nox-review, it tried to build hundreds of packages in wip mode, and dozens in pr mode, so I cancelled it :/ |
This breaks |
This causes way too much breakage: |
@dotlambda I figured as much (wrt. major version -> breakage). Unfortunately, there is already a "markdown2", so we couldn't even keep v2 around as that and switch "markdown" to v3 :/ Roughly how often do these major Python upgrades occur? |
Usually about once a month. However, I don't expect the next one to happen this year. |
I don't mind this PR staying open for a while, I'll put them into a local overlay, unless you think renaming and keeping two versions in the meantime would be a good idea? |
No, having different versions of the same package within |
42e51cf
to
c79bb24
Compare
I've removed this commit from |
I haven't touched the Python parts of nixpkgs before, so I don't know if this is at all correct.
Particularly suspicious is the change in hash length!
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)