Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.markdown: 2.6.10 -> 3.0.1 #52058

Merged
merged 1 commit into from Dec 19, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Dec 14, 2018

I haven't touched the Python parts of nixpkgs before, so I don't know if this is at all correct.
Particularly suspicious is the change in hash length!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tilpner tilpner requested a review from FRidh as a code owner December 14, 2018 14:54
@tilpner
Copy link
Member Author

tilpner commented Dec 14, 2018

@GrahamcOfBorg build pythonPackages.markdown

@tilpner
Copy link
Member Author

tilpner commented Dec 14, 2018

I tried running nox-review, it tried to build hundreds of packages in wip mode, and dozens in pr mode, so I cancelled it :/

@dotlambda
Copy link
Member

This breaks octoprint. Please add a commit that overrides the markdown version used in pkgs/applications/misc/octoprint/default.nix.

@dotlambda
Copy link
Member

This causes way too much breakage: flask-api, Nikola, pelican, ...
Therefore, we will not merge this as is but might include it in the next set of major Python upgrades.
cc @FRidh

@tilpner
Copy link
Member Author

tilpner commented Dec 14, 2018

@dotlambda I figured as much (wrt. major version -> breakage). Unfortunately, there is already a "markdown2", so we couldn't even keep v2 around as that and switch "markdown" to v3 :/

Roughly how often do these major Python upgrades occur?

@dotlambda
Copy link
Member

Roughly how often do these major Python upgrades occur?

Usually about once a month. However, I don't expect the next one to happen this year.

@tilpner
Copy link
Member Author

tilpner commented Dec 14, 2018

I don't mind this PR staying open for a while, I'll put them into a local overlay, unless you think renaming and keeping two versions in the meantime would be a good idea?

@dotlambda
Copy link
Member

No, having different versions of the same package within pythonPackages is never a sane thing to do because these different versions could both propagate into some package's build inputs.

@dotlambda dotlambda changed the base branch from master to python-unstable December 19, 2018 16:12
@dotlambda dotlambda merged commit 47b515b into NixOS:python-unstable Dec 19, 2018
@FRidh
Copy link
Member

FRidh commented Dec 25, 2018

I've removed this commit from python-unstable from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants