Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode backports #52043

Merged
merged 13 commits into from Dec 16, 2018
Merged

vscode backports #52043

merged 13 commits into from Dec 16, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Was reviewing #52036 and I recalled that we should be backporting this stuff to stable.
I've also included all changes to the vscode-extensions.

Let me know if I missed anything.

cc @Mic92 (since you brought this to our attention a bit back)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

eadwu and others added 13 commits December 14, 2018 07:55
@eadwu @worldofpeace
vscode: 1.28.2 -> 1.29.0
ca10a0e 
(cherry picked from commit a23e3b0)
@Synthetica9 @worldofpeace
vscode: 1.29.0 -> 1.29.1 (NixOS#50462)
eaa89f1 
(cherry picked from commit 874b017)
@eadwu @worldofpeace
vscode,vscode-extensions: fix insiders build
8999332 
(cherry picked from commit d41e868)
@the-kenny @worldofpeace
vscode: 1.29.1 -> 1.30.0
63e94fe 
(cherry picked from commit 38d4c09)
@eadwu @worldofpeace
vscode-extensions.ms-python.python: 2018.7.0 -> 2018.8.0 (NixOS#47572)
c58f8c0 
(cherry picked from commit 285800d)
@eadwu @worldofpeace
vscode-extensions.ms-vscode.cpptools: 0.17.6 -> 0.19.0 (NixOS#47573)
3fb0d35 
(cherry picked from commit 4c95508)
@eadwu @worldofpeace
vscode-extensions.ms-python.python: 2018.8.0 -> 2018.9.1 (NixOS#48849)
eb3f66a 
(cherry picked from commit a53a3bf)
@eadwu @worldofpeace
vscode-extensions.ms-vscode.cpptools: use mono 5 (NixOS#49489)
b02c177 
(cherry picked from commit f8ef8bf)
@eadwu @worldofpeace
vscode-extensions.ms-python.python: 2018.9.1 -> 2018.10.1
d31a5da 
(cherry picked from commit c4cb982)
@eadwu @worldofpeace
vscode-extensions.ms-vscode.cpptools: 0.19.0 -> 0.20.1
7b6192b 
(cherry picked from commit 728d2a2)
@eadwu @worldofpeace
vscode-extensions.WakaTime.vscode-wakatime: init at 1.2.3
9c853c7 
(cherry picked from commit f7b05ca)
@eadwu @worldofpeace
vscode-extensions.ms-python.python: 2018.10.1 -> 2018.11.0
18333ba 
(cherry picked from commit 7369c3a)
@eadwu @worldofpeace
vscode-extensions.WakaTime.vscode-wakatime: 1.2.3 -> 1.2.4
f227f13 
(cherry picked from commit 70092fe)
Mic92
Mic92 approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the packages, but agree that we should backport vscode.

@worldofpeace
Copy link
Contributor Author

I went ahead in tested this in a vm with xfce with

environment.systemPackages = [ 
    (pkgs.vscode-with-extensions.override {
      vscodeExtensions = with pkgs.vscode-extensions; [
        bbenoist.Nix
        ms-python.python
        ms-vscode.cpptools
        WakaTime.vscode-wakatime
      ];
    })
  ];

Also without the extensions.
Everything works as expected 👍

@Mic92 Do you think we need a darwin tester?

@Mic92
Copy link
Member

Mic92 commented Dec 14, 2018

maybe @davidak could have a short look at the macOS version.

@davidak
Copy link
Member

davidak commented Dec 14, 2018

@Mic92 i currently don't use macOS, sorry. maybe ask on #nix-darwin?

@Mic92 Mic92 merged commit f0b6661 into NixOS:release-18.09 Dec 16, 2018
@worldofpeace worldofpeace deleted the vscode/backport branch December 18, 2018 15:09
@worldofpeace worldofpeace mentioned this pull request Dec 19, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@worldofpeace @Mic92 @davidak @GrahamcOfBorg @eadwu @Synthetica9 @the-kenny