Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: update options and php ackages #52012

Merged
merged 7 commits into from Dec 17, 2018
Merged

php: update options and php ackages #52012

merged 7 commits into from Dec 17, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 14, 2018 •
edited

Motivation for this change

Update options and php ackages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Dec 16, 2018

So, I've managed to build it all. But not gone through all those build outputs to test all those binaries.

But I've tried executed binaries from the php7X derivations and they seem to work and tested composer in all versions of PHP etc.

@GrahamcOfBorg test nextcloud php-pcre

@fpletz fpletz merged commit ece13ee into NixOS:master Dec 17, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 17, 2018

Thanks!

@Izorkin Izorkin deleted the php branch December 17, 2018 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @etu @fpletz @GrahamcOfBorg