Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polyglot: init at 0.5.18 #51985

Closed
wants to merge 1 commit into from
Closed

polyglot: init at 0.5.18 #51985

wants to merge 1 commit into from

Conversation

hyperfekt
Copy link
Contributor

@hyperfekt hyperfekt commented Dec 14, 2018 •
edited

Motivation for this change

polyglot is an 'industry'-leading source code line counting tool written in ATS.

Notes
  • Once ats-pkg init at 3.2.1.8 #44887 is done and merged, we will want to switch to building with ats-pkg instead of downloading binaries.
  • It's possible this doesn't work for all architectures that have prebuilt binaries available yet, since I wasn't sure how to check what the possible system strings on other platforms are and if there need to be any other adaptations beyond those already existent (which are taken from the install script).
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hyperfekt hyperfekt force-pushed the init_polyglot branch 2 times, most recently from 12c6c92 to ca0a000 Compare December 14, 2018 04:20
@hyperfekt hyperfekt changed the title polyglot: init at 0.5.16 polyglot: init at 0.5.18 Dec 27, 2018
@bbarker
Copy link
Contributor

bbarker commented Mar 23, 2019

Any issue with merging this?

@hyperfekt
Copy link
Contributor Author

I understand I can use haskellPackages.ats-pkg to build this from source? In that case I'd probably rather change this to do that.

@bbarker
Copy link
Contributor

bbarker commented Mar 23, 2019 via email

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@hyperfekt hyperfekt closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hyperfekt @bbarker @ryantm @GrahamcOfBorg