Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grab-site: init at 2.1.11 #51986

Merged
merged 4 commits into from Dec 15, 2018
Merged

grab-site: init at 2.1.11 #51986

merged 4 commits into from Dec 15, 2018

Conversation

ivan
Copy link
Member

@ivan ivan commented Dec 14, 2018

Motivation for this change

grab-site is a web crawler that produces WARC files that can be consumed by the Internet Archive, other web archiving organizations, and WARC playback tools.

Also init new dependencies namedlist, ludios_wpull, and fb-re2.

I guess I should disclose that I am the author of grab-site, but I am not the only user.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ivan ivan requested a review from FRidh as a code owner December 14, 2018 04:45
@srhb
Copy link
Contributor

srhb commented Dec 14, 2018

@GrahamcOfBorg build grab-site

@rasendubi
Copy link
Member

ludios_wpull fails to build with Python 2.

Add disabled = ! isPy3k;

@ivan
Copy link
Member Author

ivan commented Dec 14, 2018

Thanks, updated with disabled = !isPy3k; on ludios_wpull.

@rasendubi
Copy link
Member

@GrahamcOfBorg build grab-site python27Packages.fb-re2 python27Packages.namedlist python37Packages.fb-re2 python37Packages.ludios_wpull python37Packages.namedlist

@rasendubi rasendubi merged commit 40f6f15 into NixOS:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @srhb @rasendubi @GrahamcOfBorg