Skip to content

coqPackages: recurse into the attribute set #51058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2018
Merged

coqPackages: recurse into the attribute set #51058

merged 1 commit into from
Dec 2, 2018
+3 −1

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 26, 2018

Motivation for this change

Currently, Coq packages are hidden under the coqPackages veil.

To prevent wasting hydra resources, the meta.hydraPlatforms attributes of all nested derivations are set to an empty list.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vbgl
coqPackages: recurse into the attribute set
24b1a67 
But do not build the packages on hydra.
@vbgl vbgl added the 6.topic: coq "A formal proof management system" label Nov 26, 2018
@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 26, 2018
@vbgl vbgl merged commit 527bad1 into NixOS:master Dec 2, 2018
@vbgl vbgl deleted the recurse-into-coqPackages branch December 2, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq "A formal proof management system" 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @GrahamcOfBorg